-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endogenous export #1201
Add endogenous export #1201
Conversation
@ekatef I have added this PR and the config options are added in @hazemakhalek I think you have previously come up with a similar feature in pypsa-meets-earth/pypsa-earth-sec@main...bright. Can you point me to it, so I can outline the differences? Also, what do you think of this proposal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @energyLS! Sounds like a very nice enhancement 😄
Have added a couple of comments to the code, which are quite minor though.
As for the configs, config.tutorial
currently contains a power only model, and no updates are needed here. Regarding test configurations, it would be great to add a new option to test/config.test_myopic.yaml
. The reason is that testing configs are build upon the tutorial config, so all the cross-sectoral parameters must be specified in the test configuration directly.
Could you also please update a version of the config in the tutorial and the default configs?
…-earth into endogenous_export
Dear @ekatef, thanks for reviewing! I have:
And since we haven't documented the config options of the sector-coupled version in https://pypsa-earth.readthedocs.io/en/latest/configuration.html yet, I guess there is nothing to add here at this point? Of course it should be done in general at one point :) |
Hey @energyLS, thanks a lot for implementing the changes! As a technical comment, not need to specify the particular commits. We trust you! 😉 Agree that it feels worth to have an advanced version tested for each functionality, while I'm also confident in your expertise for sector-couple modeling. To me, the test configuration looks good as it is now. Regarding documenting the config options for the sector-coupled part you are indeed absolutely right. That is clearly out of scope for this PR, but it would be definitely useful to open an issue on that. Would you mind doing that? 🙏🏽 The only very minor point left is to update the config version also in the tutorial config. Also, please feel free to add a release note! That is quite a significant update, and it would be great to have it mentioned in the release. After that I think the PR is ready to merge, unless @davide-f or @hazemakhalek have any comments. |
I trust you both. Go ahead if you feel it's ready |
Dear @ekatef, I think everthing is done now and ready to merge, however the CI currently fails due to a problem not related with this PR: |
Hey @energyLS, perfect! Thanks a lot for the changes, and opening the issue on the documentation is highly appreciated 😄 Agree on the plan: let's fix the CI and merge. |
Closes # (if applicable).
Changes proposed in this Pull Request
This PR adds the possibility of endogenous exports to the model. Previously, it was only possible to set a fixed volume of hydrogen exports (e.g. 10 TWh). This feature enables the possibility, to export hydrogen which is covered by a certain market price for hydrogen set in the config.
In detail, it adds these options:
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.