Added nanobind to test suite #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, looks like it's working! The tests are of course failing, but that's the failure I had reported. |
|
Curiously, there is a more complex failure pattern: some tests are reporting this error message In other cases, the whole interpreter crashes without writing an error message |
mattip
reviewed
Oct 6, 2023
|
Windows is failing to find the c-extensions. |
|
Now everything fails the proper way even on Windows ;) |
|
Reran the jobs to pick up new nightlies. There is now a new internal test failure from a test with this comment “taken from https://github.com/wjakob/pypy_issues at commit 03890103”, maybe now PyPy behaves the same as cpython? |
|
The windows build bot is down, so the results did not change. That 3.10 segfault is weird. |
|
CI is green, merging. Thanks @wjakob |
|
Thank you 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds nanobind to the PyPy test suite. Let's see 🤞