Recorded mock #13
Open
Recorded mock #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also useful for automated testing with a recorded mockstream
|
It is possible that a recording of this stream has no clock offset saved which leads to the following issue: sccn/xdf#23 |
agricolab
reviewed
Dec 7, 2021
| if time_diff > 0: | ||
| time.sleep(time_diff) | ||
| else: | ||
| time.sleep(0.001) | ||
|
|
There was a problem hiding this comment.
The sleep in line 188/190 exhibits a bias, as you do not account for time spent in lines 182 to 186. One option is to measure this time spent, and reduce the time slept by this time, see re.g. Clock.sleep_debiased from Pyreiz:
https://github.com/pyreiz/pyreiz/blob/master/reiz/time.py#L83-L93
There was a problem hiding this comment.
Also, sleep has an inherent positive bias, that adds up over repeated calls. Consider a self-correcting scheduler implementation, e.g. https://gist.github.com/agricolab/1f35cecea25c3e251d40057f2221f831#file-periodic_self_correcting-py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to use a pre-recorded xdf file to mock EEG data. It does not support marker streams.
It was tested with EEGO, BrainvisionRDA, and Spongebob data