-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cad_audit_check.py #2559
Conversation
Added condition to catch the case of a project with no CAD instances
Automatic code review is enabled for this repository. Reviewing this PR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the changes to handle projects with no CAD instances. The core functionality looks good, but I've suggested some improvements for robustness (explicit None handling), efficiency (removing redundant variable), and consistency (naming and formatting). These changes will help make the code more maintainable while preserving the intended functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tank you!
So I think my own patch-3 branch is OK. |
Sorry, I forgot I have the ability to do the merge and I was waiting for @jmcouffin to do it 😅 You did everything right, thank you very much for taking the time to learn git and github! |
📦 New work-in-progress (wip) builds are available for 5.0.0.25042+1512-wip |
Added condition to catch the case of a project with no CAD instances
Update cad_audit_check.py
Description