Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize contrib.epidemiology models #2499

Merged
merged 2 commits into from
May 22, 2020
Merged

Reorganize contrib.epidemiology models #2499

merged 2 commits into from
May 22, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented May 22, 2020

Addresses #2426

This pure-refactoring PR:

  1. Merges sir.py + seir.py -> models.py, since the sir/seir distinction does not seem important as we explore wider model classes
  2. Renames Overdispersed*Model -> Superspreading*Model to avoid confusion with Add overdispersed models to contrib.epidemiology #2498 which introduces more generic forms of overdispersion.

Tested

  • pure refactoring is covered by existing tests

@fritzo
Copy link
Member Author

fritzo commented May 22, 2020

@martinjankowiak are you able to merge? Travis says tests passed, but github seems confused.

@fritzo
Copy link
Member Author

fritzo commented May 22, 2020

@martinjankowiak mind if I force merge this to work around github's issues?
The tests indeed pass: https://travis-ci.com/github/pyro-ppl/pyro/builds/167795215

@fritzo fritzo merged commit 99222cf into dev May 22, 2020
@fritzo fritzo deleted the sir-rename branch June 5, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants