Resurrect num_quant_bins=2 in contrib.epidemiology #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe this is a bad idea 🤔 |
|
@martinjankowiak would you mind if we resurrected this? I'd like to see how this feature interacts with other inference tricks, and it would ease my branch management if this were in dev. |
|
|
||
| t = 1 - s | ||
|
|
||
| if num_quant_bins == 2: |
There was a problem hiding this comment.
why not the smoother cubic version?
There was a problem hiding this comment.
I think my early attempt at a 2-point cubic spline was ill-conceived and not very smooth:
martinjankowiak
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2426
This resurrects the old
compute_bin_probs(s, num_quant_bins=2). While this works horribly for general inference, I'd like to use that helper for another spline purpose.I've also switched from case-checking to return-early-with-fallthrough-exception to make further modifications simpler.
Tested