Support jit in CompartmentalModel #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjankowiak
previously approved these changes
Jun 14, 2020
| @@ -149,6 +150,7 @@ def main(args): | |||
| parser.add_argument("--single", action="store_false", dest="double") | |||
| parser.add_argument("--rng-seed", default=0, type=int) | |||
| parser.add_argument("--cuda", action="store_true") | |||
| parser.add_argument("--jit", action="store_true") | |||
There was a problem hiding this comment.
shouldn't this be on by default?
There was a problem hiding this comment.
Good question. How about we enable it on by default in the example files, but off by default in the CompartmentalModel class?
I just worry that jit_compile=True disables validation, and that if we optimize for new users we should enable validation by default. The example scripts use predefined models and don't really need validation, whereas CompartmentalModel will be the base class for new models.
There was a problem hiding this comment.
yeah that sounds like a reasonable middle ground
martinjankowiak
approved these changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2426
This supports
jit_compile=TrueinCompartmentalModel.fit(). Changes include:Tensor.__iter__()withTensor.unbind(0)to issue the correct warning type, so it can be ignored byignore_jit_warnings=True.Performance
Anecdotally about 1.6x speedup (with identical output):
python examples/contrib/epidemiology/sir.pypython examples/contrib/epidemiology/regional.py -hfm=7Tested
test_examples.py::test_jit