-
-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 RSA vectorized prior achieved; L0 doesn't enumerate #2908
base: dev
Are you sure you want to change the base?
Conversation
`structured_prior` will correctly enumerates (and specifies individual sample sites - vs making a single sample site of a tensor over all enumerations). `listener0` doesn't enumerate over the support of `structured_prior`. It strictly visits the highest probability sample from the `structured_prior`.
`structured_prior` will correctly enumerates (and specifies individual sample sites - vs making a single sample site of a tensor over all enumerations). `listener0` doesn't enumerate over the support of `structured_prior`. It strictly visits the highest probability sample from the `structured_prior`.
Conflicts: - Altered execution counters in `examples/rsa/generics-vectorized.ipynb` - Upgrade `maxsize` of memoize from 10 -> 100
@eb8680 Just a bump on this. I can update with some more work I've done with this – but right now I've hit a snag where the following doesn't appear to work: @config_enumerate
def listener0(utterance: Tensor, threshold: Tensor, States: RSAMarginal) -> Tensor:
state = pyro.sample("state", States)
# ...
return state
I can push the changes so you can inspect them if it's helpful – but at the moment, I'm not sure how to "signal" that I've searched the forum pretty extensively and haven't seen any questions about this. |
@jmuchovej sorry, I'll try to look at it this week. |
Also, a side note, I've actually replicated everything (that is, the models we're looking to build) in WebPPL. The only way to get a reasonable run-time was to use of their There's a I'm not exactly sure how WebPPL's WebPPL's docs on (Later this week, or early next week, I can try replicating the results I recall if that would be helpful.) |
structured_prior
will correctly enumerate (and specify individual sample sites - vs making a single sample site of a tensor over all enumerations).listener0
doesn't enumerate over the support ofstructured_prior
. It strictly visits the highest probability sample from thestructured_prior
.