Use dependencies in the AutoReparam strategy #2966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
commented
Nov 10, 2021
Comment on lines
-203
to
-206
| # TODO reparametrize only if parameters are variable. We might guess | ||
| # based on whether parameters are differentiable, .requires_grad. See | ||
| # https://github.com/pyro-ppl/pyro/pull/2824 | ||
|
|
There was a problem hiding this comment.
This PR resolves this TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to apply
LocScaleReparaminAutoReparamonly for latent variables whose prior distributions depends on upstream variables. In case the prior has fixed parameters, there is no need to reparametrize, and reparametrizing introduces unnecessary complexity and obfuscation.This first attempt is blocked by nuances in the interaction of
get_dependencies()withAutoReparam(), since the model's latent variables are determined only dynamically, but they want to use dependencies to determine strategy. The fix may involve subtler use ofProvenanceTensor🤔