-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rails 6.1, ruby 2.7, ruby 3.0 #77
Support rails 6.1, ruby 2.7, ruby 3.0 #77
Conversation
c415b9b
to
01870d1
Compare
@@ -1,4 +1,4 @@ | |||
%w[4.2 5.1 5.2 6.0].each do |version| | |||
%w[4.2 5.1 5.2 6.0 6.1].each do |version| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you haven't run appraisals generate
. Can you please add all the version defined here to the CI and regenerate all the gemfiles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the meaning of the question. The gemfile for 6.1.0 is in the expected folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean @pyromaniac. Git is wrongly assuming there is a rename+change from the 4.2 gemfile to the 6.1 gemfile. But it really is a completely new file, the gemfiles for 4.2 to 5.2 were removed to be able to merge into toptal/active_data fork that relies on a different CI. I'll restore the previous changes so it will be clearer.
792e242
to
01870d1
Compare
Hm, CI doesn't run. Can you make it work or tell me if you run all the rails versions locally? I think GH actions would be just fine. I can do it as well over the weekend. |
https://app.travis-ci.com/github/pyromaniac/active_data
That's awesome, looks like travis wants everyone to migrate to GHA for real. |
So if you rebase, I'll manage to merge it right away I believe. |
So this can be closed already, right? |
Yep, I included it into #80 with minor fixes. |
Better implementation of #76, that solves #75.
errors
is a mutable array now fork behavior depending on the ActiveModel version.method_missing
in ScopesReferences:
https://rubyreferences.github.io/rubychanges/3.0.html#array-always-returning-array
https://rubyreferences.github.io/rubychanges/2.7.html#keyword-argument-related-changes
https://github.com/rails/rails/blob/6-1-stable/activemodel/CHANGELOG.md