Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Commit

Permalink
Merge pull request #25 from Roxe322/master
Browse files Browse the repository at this point in the history
Fixed #24 invalid enter_room and leave_room
  • Loading branch information
pyropy authored Oct 30, 2021
2 parents 0a511cc + 3994b38 commit c20d100
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

* [Matthew D. Scholefield](https://github.com/MatthewScholefield) - Added cors allowed origins for AsyncServer [#7](https://github.com/pyropy/fastapi-socketio/pull/7)
* [Aaron Tolman](https://github.com/tolmanam) - Reported issue with broken pip download [#5](https://github.com/pyropy/fastapi-socketio/issues/5)
* [Khiem Doan](https://github.com/khiemdoan) - Helped with cleaning up old unused dependencies[#5](https://github.com/pyropy/fastapi-socketio/issues/15)
* [Khiem Doan](https://github.com/khiemdoan) - Helped with cleaning up old unused dependencies[#5](https://github.com/pyropy/fastapi-socketio/issues/15)
* [Artem Kolomatskiy](https://github.com/Roxe322) - Fixed invalid usage of enter_room and leave_room[#24](https://github.com/pyropy/fastapi-socketio/issues/24)
12 changes: 6 additions & 6 deletions fastapi_socketio/socket_manager.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from typing import Union

import socketio
from typing import Optional, Union
from fastapi import FastAPI

class SocketManager:
Expand Down Expand Up @@ -89,10 +90,9 @@ def sleep(self):
return self._sio.sleep

@property
def enter_room(self, sid: str, room: str, namespace: Optional[str] = None):
return self._sio.enter_room(sid, room, namespace)
def enter_room(self):
return self._sio.enter_room

@property
def leave_room(self, sid: str, room: str, namespace: Optional[str] = None):
return self._sio.leave_room(sid, room, namespace)

def leave_room(self):
return self._sio.leave_room

4 comments on commit c20d100

@zusorio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyropy Can you release this on pypi? I just ran into this issue and was very confused.

@pyropy
Copy link
Owner Author

@pyropy pyropy commented on c20d100 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyropy Can you release this on pypi? I just ran into this issue and was very confused.

Done

@zusorio
Copy link

@zusorio zusorio commented on c20d100 Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyropy Looks like it's still not published https://pypi.org/project/fastapi-socketio/#history

@pyropy
Copy link
Owner Author

@pyropy pyropy commented on c20d100 Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZusorCode Thanks for noticing, seems like there's some issue when publishing new package using CI.

Please sign in to comment.