Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: fix test, rm log action, ruff-format #533

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

martinfleis
Copy link
Member

@martinfleis martinfleis commented Jan 9, 2024

Fixing the issue in dev CI (that is actually a regression on dev GeoPandas but we can avoid it) and removing the xarray-contrib/issue-from-pytest-log action that does not work.

edit: also resolves #531
edit2: adopt ruff-format

@martinfleis martinfleis requested a review from jGaboardi January 9, 2024 14:12
@martinfleis martinfleis self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (295c21d) 97.5% compared to head (f7435e3) 97.5%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #533     +/-   ##
=======================================
- Coverage   97.5%   97.5%   -0.0%     
=======================================
  Files         24      24             
  Lines       4123    4121      -2     
=======================================
- Hits        4020    4018      -2     
  Misses       103     103             
Files Coverage Δ
momepy/preprocessing.py 94.2% <ø> (ø)
momepy/shape.py 91.5% <ø> (ø)
momepy/tests/test_elements.py 100.0% <100.0%> (ø)
momepy/utils.py 98.8% <ø> (ø)

@martinfleis martinfleis changed the title CI/TST: fix test, rm log action CI/TST: fix test, rm log action, ruff-format Jan 9, 2024
momepy/preprocessing.py Outdated Show resolved Hide resolved
Co-authored-by: James Gaboardi <[email protected]>
@martinfleis martinfleis merged commit 2051f4b into pysal:main Jan 9, 2024
7 of 9 checks passed
@martinfleis martinfleis deleted the report_error branch January 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants