Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove np.float due to deprecation error #32

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

Ziqi-Li
Copy link
Member

@Ziqi-Li Ziqi-Li commented Jan 10, 2023

At this line, Numpy 1.24 will raise an error for np.float, which is deprecated. This causes error in downstream mgwr's auto testing.

Numpy 1.24 release note

At [this line](https://github.com/pysal/spglm/blob/7b00f42eaee795142e90aba2435d4ce34e8613fe/spglm/iwls.py#L111), Numpy 1.24 will raise an error for `np.float` which is deprecated. This causes error in downstream `mgwr`'s auto testing.

[Numpy 1.24 release note](https://numpy.org/devdocs/release/1.24.0-notes.html#expired-deprecations)
@Ziqi-Li Ziqi-Li merged commit 615d63e into pysal:master Jan 10, 2023
@martinfleis
Copy link
Member

martinfleis commented Oct 12, 2023

This is affecting current fresh environments. Can we cut a patch release that includes this?

@jGaboardi jGaboardi mentioned this pull request Oct 12, 2023
@jGaboardi
Copy link
Member

This is affecting current fresh environments. Can we cut a patch release that includes this?

It has been a very long time since I have done a release without our modern GHA tooling. If we can wait until the completion of #43, then I can take of it.

@martinfleis
Copy link
Member

Agree to get #43 in first.

We will also need @TaylorOshan to share PyPI rights or add a token later. But there's currently only a single person with PyPI access, it would be wise to share it anyway with someone else (@jGaboardi?).

@jGaboardi
Copy link
Member

Agree to get #43 in first.

We will also need @TaylorOshan to share PyPI rights or add a token later. But there's currently only a single person with PyPI access, it would be wise to share it anyway with someone else (@jGaboardi?).

Yes, we will need PyPI rights... Can @ljwolf or @sjsrey help with this?

@martinfleis
Copy link
Member

No, only @TaylorOshan has PyPI rights here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants