Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attributes & functionality for locate models #296

Merged
merged 14 commits into from
Nov 8, 2022

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 31, 2022

This PR:

@jGaboardi jGaboardi self-assigned this Oct 31, 2022
@jGaboardi
Copy link
Member Author

xref #295 needs attention in the short term.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #296 (8c072af) into main (799cd86) will increase coverage by 0.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #296     +/-   ##
=======================================
+ Coverage   73.2%   73.7%   +0.5%     
=======================================
  Files         23      23             
  Lines       2402    2421     +19     
  Branches     459     463      +4     
=======================================
+ Hits        1758    1785     +27     
+ Misses       580     578      -2     
+ Partials      64      58      -6     
Impacted Files Coverage Δ
spopt/locate/util.py 100.0% <ø> (ø)
spopt/locate/base.py 95.1% <100.0%> (+0.1%) ⬆️
spopt/locate/coverage.py 100.0% <100.0%> (+1.0%) ⬆️
spopt/locate/p_center.py 100.0% <100.0%> (+1.5%) ⬆️
spopt/locate/p_dispersion.py 100.0% <100.0%> (+9.3%) ⬆️
spopt/locate/p_median.py 100.0% <100.0%> (+1.5%) ⬆️

Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jGaboardi! Wow, nice improvements! I made minor comments.

spopt/tests/test_locate.py Outdated Show resolved Hide resolved
spopt/locate/coverage.py Show resolved Hide resolved
spopt/tests/test_lscpb.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi merged commit 2ac4039 into pysal:main Nov 8, 2022
@jGaboardi jGaboardi deleted the new_attributes_etc branch November 8, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment