Skip to content

Commit

Permalink
Install mypy on direct CI jobs to run new tests
Browse files Browse the repository at this point in the history
Also remove pytest-pep8 as it is obsolete and these CI jobs were not
in fact running pep8 linting anyway.

Make importing Literal compatible with Python 3.7 in pysam/libctabix.pyi
similarly to other pysam/*.pyi files.
  • Loading branch information
jmarshall committed Oct 22, 2024
1 parent bf5b85e commit 905c9e2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install prerequisite Python libraries
run: pip install cython pytest pytest-pep8 setuptools
run: pip install cython mypy pytest setuptools

- name: Install Linux build prerequisites
if: runner.os == 'Linux'
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install prerequisite Python libraries
run: pip install cython pytest pytest-pep8
run: pip install cython pytest

- name: Install build prerequisites
if: runner.os == 'Linux'
Expand Down
8 changes: 7 additions & 1 deletion pysam/libctabix.pyi
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
from typing import Optional, Literal, List, Any
import sys
from typing import Optional, List, Any

if sys.version_info < (3, 8):
from typing_extensions import Literal
else:
from typing import Literal

from pysam.libchtslib import HTSFile

Expand Down

0 comments on commit 905c9e2

Please sign in to comment.