Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disl triples #130

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Add disl triples #130

merged 13 commits into from
Jun 25, 2024

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Jun 25, 2024

Add triples for dislocation generation. The arguments of the create dislocation function is also changed for clarity. Example here.

@srmnitc srmnitc requested a review from aazocar June 25, 2024 11:43
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.11%. Comparing base (1a42866) to head (f70380e).

Files Patch % Lines
atomrdf/structure.py 84.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   61.51%   62.11%   +0.60%     
==========================================
  Files          22       22              
  Lines        2993     3049      +56     
==========================================
+ Hits         1841     1894      +53     
- Misses       1152     1155       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

atomrdf/structure.py Show resolved Hide resolved
atomrdf/structure.py Outdated Show resolved Hide resolved
atomrdf/structure.py Show resolved Hide resolved
Copy link
Collaborator

@aazocar aazocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@srmnitc srmnitc merged commit d8a3d78 into main Jun 25, 2024
7 checks passed
@srmnitc srmnitc deleted the add_disl_triples branch June 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants