remove boost shared library link from header only test suite #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started running Fedora 40 on my personal laptop and found that SWMM wouldn't pass unit tests on that OS. Fedora is known for running newer software than debian/ubuntu and I wanted to understand why the tests would not pass. I was getting all sorts of malloc errors suggesting there was a memory leak in boost, but I doubted that could be true.
Turns out our Boost.Test configuration is not quite correct and breaks in newer versions of our linux build stack (gcc/cmake/boost). Our Solver, LID, and output test suites are configured as header-only suites, but cmake is configured to link boost as if our tests are configured as the shared variant.
After consulting the cmake docs and boost docs, I thought it best to remove the boost link....which solved my issues on fedora 40.
Regression tests still are failing on mac and windows, but that's a separate issue entirely.