Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efficient implementation of attention #275

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

Coerulatus
Copy link
Collaborator

Hello,
@levtelyatnikov and I made some changes to allset_transformer_layer.
We noticed that the old implementation required a lot of memory when calculating the attention scores when dealing with large graphs. Now the layer achieves the same results with less memory requirements.
We also introduced a LeakyReLU activation when calculating the attention as per the official code implementation (lines 168-177).
Thank you very much.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (2267768) to head (d702faf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          58       58           
  Lines        2054     2058    +4     
=======================================
+ Hits         2000     2004    +4     
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@ninamiolane ninamiolane merged commit b70ece9 into main May 14, 2024
24 checks passed
@ninamiolane ninamiolane deleted the allsettransformer_efficient branch May 14, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants