Fake io open #109
Merged
Fake io open #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrbean-bremen
commented
Jun 12, 2016
mrbean-bremen
commented
- redirects to FakeFileOpen
- fixes python3 - io.open not redirected to fake file system #70 and zipfile.ZipFile does not create file in fake file system on Windows with Python 2.7.9 #103
- redirects to FakeFileOpen - fixes pytest-dev#70 and pytest-dev#103
- redirects to FakeFileOpen - fixes pytest-dev#70 and pytest-dev#103
|
Looks good. I'll merge this after you fix the minor issue in #107. |
|
Another fine contribution from @mrbean-bremen. |
|
@jmcgeheeiv thanks for fixing it. Was it released to pypi? What version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.