Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing the scenario for multiple example tables #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olegpidsadnyi
Copy link
Contributor

Cucumber has added multiple example tables to the scenarios. These examples can also get tags.
We need to support pytest marks for those examples.
The parser is going to add multiple example tables to the TemplatedScenario. The tags can become part of the Examples object.
Since each test item is produced by the parametrization represented by a single table row we have to pass the marks parameter to each of them.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #489 (d52dea9) into master (f4ed62d) will decrease coverage by 0.09%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   95.91%   95.82%   -0.10%     
==========================================
  Files          49       49              
  Lines        1640     1651      +11     
  Branches      179      181       +2     
==========================================
+ Hits         1573     1582       +9     
- Misses         41       42       +1     
- Partials       26       27       +1     
Impacted Files Coverage Δ
pytest_bdd/scenario.py 90.90% <84.61%> (-0.76%) ⬇️
pytest_bdd/parser.py 99.54% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ed62d...d52dea9. Read the comment docs.

@olegpidsadnyi
Copy link
Contributor Author

@elchupanebrej have a look. I started sketching out some preparations for the multiple scenario examples

@youtux youtux added this to the Gherkin-compliant milestone Mar 6, 2022
@mawaliya
Copy link

Hi, what is the status of this ticket?

@blaisep
Copy link

blaisep commented Apr 5, 2024

@olegpidsadnyi ,
#378 (comment)

@ChernyavskiyAlex
Copy link

Hi @youtux, is there any chance that something similar will be delivered within 8.0.0 release?

@youtux
Copy link
Contributor

youtux commented Oct 16, 2024

@jsa34 do we support this out of the box now that we are using the official parser?

@jsa34
Copy link
Collaborator

jsa34 commented Oct 16, 2024

Ooh good question... I'll take a look

@ChernyavskiyAlex
Copy link

@jsa34 according to my observations gherkin parser provides tags but they are not taking into consideration on pytest-bdd side when execution "from_dict" methods

@youtux youtux mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants