Issue #362: Only unconfigure if configured #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtux
requested changes
Oct 29, 2023
|
Thanks for the fix, if you can address the comments I'll happily merge this fix |
n3world
force-pushed
the
issue_362_unconfigure
branch
from
1e736b6
to
718b986
Compare
`pytest_unconfigure` can be called even if `pytest_configure` was not. In order to avoid errors during unconfigure only perform the unconfigure if the configure was performed. Add a counter which is incremented before configure to track the number of times pytest started initialization so that the config is not popped early from the stack.
n3world
force-pushed
the
issue_362_unconfigure
branch
from
718b986
to
825fcf8
Compare
|
I also resolved the unit test failures from previous run |
youtux
approved these changes
Nov 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 95.45% 95.46% +0.01%
==========================================
Files 49 49
Lines 1783 1788 +5
Branches 195 196 +1
==========================================
+ Hits 1702 1707 +5
Misses 53 53
Partials 28 28
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest_unconfigurecan be called even ifpytest_configurewas not. In order to avoid errors during unconfigure only perform the unconfigure if the configure was performed. Add a counter which is incremented before configure to track the number of times pytest started initialization so that the config is not popped early from the stack.