Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the official gherkin parser #698

Merged
merged 40 commits into from
Sep 21, 2024
Merged

Implement the official gherkin parser #698

merged 40 commits into from
Sep 21, 2024

Commits on Sep 5, 2024

  1. First commit for using the official gherkin parser (trying to maintai… 

    …n public API and current codebase as much as possible)
    @jsa34
    jsa34 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1a2baff View commit details
    Browse the repository at this point in the history

  2. Improve docstrings in parser.py

    @jsa34
    jsa34 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    65c06e4 View commit details
    Browse the repository at this point in the history

  3. Improve docstrings in parser.py

    @jsa34
    jsa34 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    abe5e79 View commit details
    Browse the repository at this point in the history

  4. Fix issues and create a FeatureParser class to consolidate parsing logic

    @jsa34
    jsa34 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    240ac6d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Forgot to go back and implement the templated bool

    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e7b5326 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2f3e029 View commit details
    Browse the repository at this point in the history

  3. Move Gherkin parsing to pydantic models for easier future reference o… 

    …f available data and implementing features.
    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cc9b37f View commit details
    Browse the repository at this point in the history

  4. Move the calculating of given/when/then to pydantic models, as well a… 

    …s removing tabbing from docstring in steps (aka multiline steps)
    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4e17ccb View commit details
    Browse the repository at this point in the history

  5. Fix silly mistakes

    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    57b9e55 View commit details
    Browse the repository at this point in the history

  6. Fix type hints for py3.8

    @jsa34
    jsa34 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ff1a926 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Response to feedback

    @jsa34
    jsa34 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    21afdb1 View commit details
    Browse the repository at this point in the history

  2. Another grammar fix

    @jsa34
    jsa34 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fec8270 View commit details
    Browse the repository at this point in the history

  3. Use dataclasses and not attr

    @jsa34
    jsa34 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6676692 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Response to feedback

    @jsa34
    jsa34 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    becfed2 View commit details
    Browse the repository at this point in the history

  2. Response to feedback

    @jsa34
    jsa34 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2c8455b View commit details
    Browse the repository at this point in the history

  3. Couple of tidy ups

    @jsa34
    jsa34 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c3008c1 View commit details
    Browse the repository at this point in the history

  4. Forgot to fix background in steps and revert test that was skipped

    @jsa34
    jsa34 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9c12dbf View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Fix import (Python < 3.11 compat)

    @youtux
    youtux committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    93a11ae View commit details
    Browse the repository at this point in the history

  2. Remove default to None

    @youtux
    youtux committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    fee0eb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Revert string literals to their original form

    @youtux
    youtux committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    7cbfc47 View commit details
    Browse the repository at this point in the history

  2. Response to feedback and make mypy happy.

    @jsa34
    jsa34 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    2f3acbd View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/gherkin-official-parser' into gh… 

    …erkin-official-parser
    @jsa34
    jsa34 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    9b45269 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Do not fail the CI job if we can't upload to Codecov. 

    Also bump codecov-action
    @youtux
    youtux committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a3a5195 View commit details
    Browse the repository at this point in the history

  2. Ignore py3.13 failures for now 

    They are not really failures, just deprecation warnings that we treat as errors.
    @youtux
    youtux committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    656c7ce View commit details
    Browse the repository at this point in the history

  3. Fix matching result in case there are warnings

    @youtux
    youtux committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d11096f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Remove accidentally committed local file. 

    Fix test file name
    @jsa34
    jsa34 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0a77782 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/gherkin-official-parser' into gh… 

    …erkin-official-parser
    @jsa34
    jsa34 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    2941d18 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gherkin-official-parser 

    # Conflicts:
#	CHANGES.rst
    @jsa34
    jsa34 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    9801a28 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fork/jsa34/gherkin-official-parser

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ca7508b View commit details
    Browse the repository at this point in the history

  5. Update release notes

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    093b6a8 View commit details
    Browse the repository at this point in the history

  6. Require tests to pass on 3.13

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    5f717c4 View commit details
    Browse the repository at this point in the history

  7. Only treat warnings from pytest_bdd as exceptions

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0fe4419 View commit details
    Browse the repository at this point in the history

  8. Add type annotations

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    9b263f4 View commit details
    Browse the repository at this point in the history

  9. remove redundant statements

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    6fe8e40 View commit details
    Browse the repository at this point in the history

  10. Fix typing issue

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0573c6f View commit details
    Browse the repository at this point in the history

  11. Add missing type annotations, and require all files to be typed

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    8629438 View commit details
    Browse the repository at this point in the history

  12. mypy is passing, require typecheck outcome to be positive

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ace6ca5 View commit details
    Browse the repository at this point in the history

  13. Remove declaration for field that was never initialised

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    c12d8c1 View commit details
    Browse the repository at this point in the history

  14. Remove unused function

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    8378a34 View commit details
    Browse the repository at this point in the history

  15. Update poetry

    @youtux
    youtux committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    572934c View commit details
    Browse the repository at this point in the history