add --disable-plugin-autoload #13253
Open
+150
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have answers for those questions, sorry, but I'm happy to say that the PR is looking good overall, and I'm looking forward to merging it once they're resolved and CI is green 🙂 |
psf-chronographer
bot
added
the
bot:chronographer:provided
|
I can't repro the pypy fail locally, but I'm not sure if spec matters, so ?? I've updated comments to something that almost makes sense to merge with, but ... it's a mess. |
Zac-HD
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
This looks good to me, but I'd appreciate a second opinion before merging. Maybe @nicoddemus?
| else: | ||
| assert PseudoPlugin.attrs_used == [] | ||
| # it should load if it's enabled, or we haven't disabled autoloading | ||
| assert has_loaded == bool(enable_plugin_method) or not disable_plugin_method |
There was a problem hiding this comment.
using parens here would be good to make the precedence more obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8969
I'm pretty sure the implementation is solid, but I have a bunch of question marks in comments that should be resolved before merging. I can probably resolve them on my own by digging deep enough into the innards, but wouldn't mind explanations if somebody is more familiar with that territory.
I'm not entirely sure that
test_installed_plugin_rewriteshould be parametrized to hell, as opposed to creating a dedicated test.I also found a random unrelated typo in
test_installed_plugin_rewritewithcheck_first->check_first2, so fixed that + improved thefnmatch_lines.changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.