Skip to content

chore: fix some minor issues in comments #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ This page contains useful tools for publishers to analyse, monitor and review th
- [Pyth Price Feeds & Metrics](https://pyth.network/price-feeds): Publishers can review their price data metrics for permissioned symbols. The conformance logs that can be downloaded contain useful metrics that show publisher uptime, price deviations and alerts. The metrics page can be accessed by selecting the environment > symbol > publisher key tab
- [Pyth Publisher Ranking Page](https://pyth.network/publishers/ranking): This page provides a full breakdown of publisher ranking and inactive/active price feeds
- [Pyth Agent API GitHub Repository](https://github.com/pyth-network/pyth-agent): This repository contains the latest release for the Pyth-Agent API
- [Solana Explorer](https://explorer.solana.com): Solana Explorer allows publishers to monitor their public keys balance and transactions. It also provides live cluster statistics. For Pythnet or Pythtest, publishers should select 'Custom RPC URL' and add the the RPC http URL
- [Solana Explorer](https://explorer.solana.com): Solana Explorer allows publishers to monitor their public keys balance and transactions. It also provides live cluster statistics. For Pythnet or Pythtest, publishers should select 'Custom RPC URL' and add the RPC http URL
- [Pythnet Statistics](https://pyth.network/stats): A useful tool to review pythnet uptime per publisher key
2 changes: 1 addition & 1 deletion doc/rust-code-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ The recommendations on this page should help with dealing with these lints.

Refer also to [Clippy lints documentation](https://rust-lang.github.io/rust-clippy/master/index.html) for more information about the lints.

If the lint is a false positive, put `#[allow(lint_name, reason = "...")]` on the relevant line or block and and specify the reason why the code is correct.
If the lint is a false positive, put `#[allow(lint_name, reason = "...")]` on the relevant line or block and specify the reason why the code is correct.

Many of the lints (e.g. most of the panic-related lints) can be allowed globally for tests and other non-production code.

Expand Down
4 changes: 2 additions & 2 deletions price_service/client/js/src/PriceServiceConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export class PriceServiceConnection {
* Fetch latest VAA of given price ids.
* This will throw an axios error if there is a network problem or the price service returns a non-ok response (e.g: Invalid price ids)
*
* This function is coupled to wormhole implemntation.
* This function is coupled to wormhole implementation.
*
* @param priceIds Array of hex-encoded price ids.
* @returns Array of base64 encoded VAAs.
Expand All @@ -180,7 +180,7 @@ export class PriceServiceConnection {
* is old and the price service endpoint does not have a db backend for historical requests.
* This will throw an axios error if there is a network problem or the price service returns a non-ok response (e.g: Invalid price id)
*
* This function is coupled to wormhole implemntation.
* This function is coupled to wormhole implementation.
*
* @param priceId Hex-encoded price id.
* @param publishTime Epoch timestamp in seconds.
Expand Down
2 changes: 1 addition & 1 deletion pythnet/pythnet_sdk/src/accumulators/mul.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::{
/// A multiplication based Accumulator
///
/// This accumulator relies on the quasi-commutative nature of the multiplication operator. It's
/// here mostly as a an example to gain intuition for how accumulators should function. This
/// here mostly as an example to gain intuition for how accumulators should function. This
/// implementation relies on the fact that `/` can be used to "remove" an element but typically an
/// accumulator cannot rely on having a shortcut, and must re-accumulate sans the element being
/// proved to be a member.
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/contracts/pulse/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Pulse replaces the service formerly known as "scheduler" or "price pusher," and
Run `forge build` to build the contracts and `forge test` to run the contract unit tests.
The unit tests live in the `../../forge-test` directory.

Gas benchmarks that cover the most frequent usage patterns are in `PulseSchedulerGasBenchmark.t.sol`. Run the benchmark with -vv to to see the gas usage for the operations under test, without setup costs.
Gas benchmarks that cover the most frequent usage patterns are in `PulseSchedulerGasBenchmark.t.sol`. Run the benchmark with -vv to see the gas usage for the operations under test, without setup costs.

## Architecture

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ contract PythUtilsTest is Test, WormholeTestUtils, PythTestUtils, IPythEvents {

// Test 4: Basic Tests with positive exponents
assertCrossRateEquals(100, 2, 100, 2, -5, 100000); // 100 * 10^2 / 100 * 10^2 = 10000 / 10000 = 1 == 100000 * 10^-5
// We will loose preistion as the the target exponent is 5 making the price 0.00001
// We will loose preistion as the target exponent is 5 making the price 0.00001
assertCrossRateEquals(100, 8, 100, 8, 5, 0);

// Test 5: Different Exponent Tests
Expand Down