Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #244

Closed
wants to merge 21 commits into from
Closed

Add type annotations #244

wants to merge 21 commits into from

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 15, 2019

I have used MonkeyType when running the tests that automatically added the type hints.

Then I went over all the changes and fixed (or simplified) the things.

@basnijholt basnijholt force-pushed the mypy branch 9 times, most recently from cdf369d to 54a6726 Compare December 15, 2019 18:18
@basnijholt basnijholt changed the title WIP: Add type annotations Add type annotations Dec 15, 2019
@basnijholt basnijholt force-pushed the mypy branch 3 times, most recently from e959e8c to 91c1ebd Compare December 15, 2019 22:01
@basnijholt
Copy link
Member Author

@akhmerov and @jbweston, I am done with this.

The only thing that has room for improvement, is the loss functions of the LearnerND. However, since we might deprecate that code, I didn't invest too much time.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #244 into master will increase coverage by 0.22%.
The diff coverage is 96.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   79.52%   79.74%   +0.22%     
==========================================
  Files          32       32              
  Lines        4401     4469      +68     
  Branches      810      810              
==========================================
+ Hits         3500     3564      +64     
- Misses        776      778       +2     
- Partials      125      127       +2
Impacted Files Coverage Δ
adaptive/_version.py 48.14% <100%> (+0.48%) ⬆️
adaptive/learner/skopt_learner.py 59.7% <100%> (+1.23%) ⬆️
adaptive/learner/learner1D.py 91.89% <100%> (-0.44%) ⬇️
adaptive/learner/learner2D.py 78.49% <100%> (+0.1%) ⬆️
adaptive/utils.py 83.05% <100%> (+0.59%) ⬆️
adaptive/learner/triangulation.py 85.2% <100%> (+0.31%) ⬆️
adaptive/learner/balancing_learner.py 74.46% <100%> (+0.69%) ⬆️
adaptive/learner/data_saver.py 88.88% <100%> (+0.65%) ⬆️
adaptive/learner/integrator_learner.py 88.17% <100%> (+0.23%) ⬆️
adaptive/learner/integrator_coeffs.py 95.34% <100%> (+0.05%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeb5ef...100f289. Read the comment docs.

@basnijholt basnijholt force-pushed the mypy branch 5 times, most recently from 30cded3 to 614f599 Compare December 20, 2019 17:27
@jbweston jbweston self-requested a review April 28, 2020 20:00
@jbweston
Copy link
Contributor

I've put this on my review backlog

@basnijholt
Copy link
Member Author

Closing.

This is superseded by #370, #371, #372, #373, #374, #375, #376, #377, #378, and #379.

@basnijholt basnijholt closed this Oct 12, 2022
@basnijholt basnijholt deleted the mypy branch October 12, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants