-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations #244
Closed
Closed
Add type annotations #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
mypy
branch
9 times, most recently
from
December 15, 2019 18:18
cdf369d
to
54a6726
Compare
basnijholt
commented
Dec 15, 2019
basnijholt
force-pushed
the
mypy
branch
3 times, most recently
from
December 15, 2019 22:01
e959e8c
to
91c1ebd
Compare
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 79.52% 79.74% +0.22%
==========================================
Files 32 32
Lines 4401 4469 +68
Branches 810 810
==========================================
+ Hits 3500 3564 +64
- Misses 776 778 +2
- Partials 125 127 +2
Continue to review full report at Codecov.
|
basnijholt
force-pushed
the
mypy
branch
5 times, most recently
from
December 20, 2019 17:27
30cded3
to
614f599
Compare
I've put this on my review backlog |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used MonkeyType when running the tests that automatically added the type hints.
Then I went over all the changes and fixed (or simplified) the things.