Skip to content

chore: Update redis-py<7 & python >= 3.9 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nsteinmetz
Copy link

@nsteinmetz nsteinmetz commented May 15, 2025

  • redis-py 6.x was released
    • redis-py 6.x covers all current supported version of redis and had some breaking changes - so 6.x is the new minimal requirement.
    • Removed the _disconnect_case related test as it no longer exists in redis-py
  • python 3.8 is EOL
  • Added python 3.13
  • Bump dependencies versions

redis-py 6.x was released
python 3.8 is EOL
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
arq/connections.py 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   96.27%   96.02%   -0.25%     
==========================================
  Files          11       11              
  Lines        1074     1082       +8     
  Branches      209      144      -65     
==========================================
+ Hits         1034     1039       +5     
- Misses         19       21       +2     
- Partials       21       22       +1     
Files with missing lines Coverage Δ
arq/jobs.py 98.15% <100.00%> (ø)
arq/logs.py 100.00% <100.00%> (ø)
arq/typing.py 100.00% <100.00%> (+9.52%) ⬆️
arq/utils.py 100.00% <100.00%> (ø)
arq/version.py 100.00% <100.00%> (ø)
arq/worker.py 97.17% <100.00%> (+<0.01%) ⬆️
arq/connections.py 87.50% <87.50%> (-2.57%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a911f3...3ad4b19. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nsteinmetz
Copy link
Author

nsteinmetz commented May 15, 2025

@samuelcolvin what is the strategy / best way to upgrade versions of components ? Such as ruff or pydantic-core ?

Fixed ✅

@nsteinmetz nsteinmetz force-pushed the patch-1 branch 2 times, most recently from 2b8046a to dc0650b Compare May 15, 2025 10:43
@nsteinmetz
Copy link
Author

nsteinmetz commented May 15, 2025

I don't know how to fix this one:

❯ make mypy             
mypy arq
arq/connections.py:104: error: Missing type parameters for generic type "ConnectionPool"  [type-arg]
arq/connections.py:244: error: Argument "sentinels" to "Sentinel" has incompatible type "str | list[tuple[str, int]]"; expected "Iterable[tuple[str, int]]"  [arg-type]
arq/connections.py:249: error: Redundant cast to "ArqRedis"  [redundant-cast]
arq/worker.py:873: error: "ArqRedis" has no attribute "aclose"  [attr-defined]
arq/worker.py:914: error: "ArqRedis" has no attribute "aclose"  [attr-defined]
Found 5 errors in 2 files (checked 12 source files)

Fixed ✅

@nsteinmetz nsteinmetz force-pushed the patch-1 branch 5 times, most recently from a2dbe0c to e4b6346 Compare May 15, 2025 12:43
@nsteinmetz
Copy link
Author

@samuelcolvin : please review the changes, I'm not sure about all of them.

Due to all changes, it may be worth bumping to 0.27 ?

@nsteinmetz
Copy link
Author

@JonasKs @samuelcolvin after reading #437 - is this PR worth ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants