Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Pass sdist into cibuildwheel directly #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on May 28, 2024

  1. 🐛🧪 Fix referencing GHA artifact @ whl builders

    It wasn't obvious right away, but referencing a job in the
    `${{ needs }}` context that is not being depended on, and does not
    even exist, silently returned an empty string for the whole expression
    passed to the `name:` input of the `download-artifact` action
    invocations. This subsequently triggered the behavior of said action to
    change to "download all the artifacts that exist in the workflow".
    This "download all" behavior has an additional quirk, though — it
    downloads each artifact in a subdirectory named after the artifact name.
    The behavior of the "download one specific artifact" mode, on the other
    hand, is different in that it does not create an extra level of nesting.
    This was the reason why it felt necessary to unpack two-levels deep
    sdist tarballs in the first place.
    
    With this patch, references to said sdists will change.
    webknjaz committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2bea383 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e60e2a View commit details
    Browse the repository at this point in the history
  3. 🧪 Pass sdist into cibuildwheel directly

    This patch also brings a copy of `cibuildwheel` in through the GitHub
    Actions interface instead of PyPI.
    webknjaz committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2eda2d1 View commit details
    Browse the repository at this point in the history