Update hooks example to handle redirection #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2022 16:26
Previously redirection information was lost by the postparsing hooks add_whitespace_hook() and downcase_hook(). This was fine for this simple shell, but sets a bad example for more complicated use cases. To fix this, when parsing the new Statement object, include the `post_command` attribute from the original Statement.
Not necessary for the sake of the example, but might help some curious individuals get a better feel for how the system works.
anselor
previously approved these changes
Feb 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 22 22
Lines 5695 5695
=======================================
Hits 5611 5611
Misses 84 84 Continue to review full report at Codecov.
|
|
@tleonhardt The lint check is failing on unrelated files. I think something in |
|
@anselor I merged in a fix for the |
|
@caseploeg Thank you for the PR! Please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously redirection information was lost by the postparsing hooks add_whitespace_hook() and downcase_hook(). This was fine for this simple shell, but sets a bad example for more complicated use cases. I made this mistake in my own application where I set up a hook to augment a Statement's arguments, but lost redirection information by accident. A very sticky bug to try and figure out why piping suddenly no longer works.
To fix this, when parsing the new Statement object, include the
post_commandattribute from the original Statement. I also made some slight organizational changes that should make it more obvious what's happening in the example.I also add a postcommand hook that hopefully provides some more intuition on the hook lifecycle by updating the prompt with the raw contents of the command last entered. I have this feature locked behind the debug option. I imagine this could help someone figure out the consequences of registering new hooks.
related to #1000