Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tags relating modules #2236

Closed
wants to merge 4 commits into from
Closed

New tags relating modules #2236

wants to merge 4 commits into from

Conversation

CaedenPH
Copy link
Contributor

@CaedenPH CaedenPH commented Jul 31, 2022

Creates 3 new tags:

  • Module-not-found
  • Modules
  • Multiple-python

Implements python-discord/meta#191 and python-discord/meta#189

@CaedenPH CaedenPH changed the title feat: Multiple-python tag New tags relating modules Jul 31, 2022
@HassanAbouelela
Copy link
Member

Thanks for the contribution, but were these approved or discussed? If so, please link the issue or discussion here. Generally we separate different features (tags in this case) in different PRs so it’s easier to review and track.

@CaedenPH
Copy link
Contributor Author

Thanks for the contribution, but were these approved or discussed? If so, please link the issue or discussion here. Generally we separate different features (tags in this case) in different PRs so it’s easier to review and track.

No, apologies, I was not aware that I had to create an issue. Should I close the pr and make an issue?

@HassanAbouelela
Copy link
Member

No it’s alright, we’ll keep this open. I do however recommend opening issues for them on the meta repo and linking this PR to get people’s eyes on them.

@minalike
Copy link
Member

minalike commented Aug 7, 2022

Hi @CaedenPH, could I ask you to review this PR which I believe covers at least one of your suggested tag contents? #2230

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Aug 7, 2022

Hi @CaedenPH, could I ask you to review this PR which I believe covers at least one of your suggested tag contents? #2230

Done, perhaps the information of that tag could be included/merged into my tags.

@AbooMinister25
Copy link

So, in regards to your last tag (Multiple-python), we already have a dashmpip tag which covers installing packages with python -m pip, and its relation to multiple python versions.

@CaedenPH CaedenPH closed this by deleting the head repository Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants