fix: Replace unfriendly error messages #3194
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenanigansd
approved these changes
Nov 7, 2024
shenanigansd
changed the title
Reviewed msgs that looked hurtful and not desirable And offered to replace with some alternative joke options refactor: error should start with capital errors Co-authored-by: Bradley Reynolds <[email protected]>
wookie184
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Looks good. I'll merge when the suggested change is resolved.
ERROR_REPLIES doesn't seem to be used anywhere, so those changes wont actually do anything. sir-lancebot has a copy of the same replies and it does use them, so it would be more useful to change them there, just noting.
We should move the lists into bot-core so we don't have this duplication, but that's a separate issue.
| @@ -627,7 +627,7 @@ class _Keys(EnvConfig, env_prefix="api_keys_"): | |||
| "Not likely.", | |||
| "No way, José.", | |||
| "Not in a million years.", | |||
| "Fat chance.", | |||
| "I would love to, but unfortunately ... no.", | |||
There was a problem hiding this comment.
Suggested change
| "I would love to, but unfortunately ... no.", | |
| "I would love to, but unfortunately... no.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed msgs that looked hurtful and not desirable And offered to replace with some alternative joke options
addressing #3152
Relevant discussion: https://discord.com/channels/267624335836053506/429409067623251969/1303867812854497303