Sir Robin Error Handling & Help Command updates #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves these commands into the core folder for better organization. This also shamelessly copies over the help command from Sir Lancebot for better formatting and pagination. This also updates some of the checks we handle for the error handling.
This overhauls how we check for whitelists. It uses the Python approach rather than the Sir Lancebot approach. It also cleans up some unused decorators to keep things tidy.
ChrisLovering
requested changes
Nov 28, 2023
I managed to get poetry unfucked and can run precommit linting again!
This commit makes a compromise. The top level command group can be run anywhere. This allows the sub-group decorators to behave properly. Now, if a `role_override` is provided to the `in_whitelist` check, anyone with that role does not have to obey channel restrictions. This commits also adds a more explicit SilentFail error to catch. If you want something to truly silently fail, we can now do that.
ChrisLovering
requested changes
Nov 29, 2023
Less responsibility for me 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and touches up the
&helpcommand output and some of the error handling. In addition, it also fixes how the channel whitelist works.