get rid of command_line_params

we don't need a separate RuntimeParameters method to parse a string,
instead we can just do this in pyro_sim.py and then use the existing
set_val method from a dict.  This also allows us to simplify the
confusing Pyro() interface.

pyro/pyro_sim.py

@@ -9,7 +9,9 @@
 
 import pyro.util.io_pyro as io
 import pyro.util.profile_pyro as profile
-from pyro.util import compare, msg, runparams
+from pyro.util import compare, msg
+from pyro.util.runparams import RuntimeParameters, _get_val
+
 
 valid_solvers = ["advection",
                  "advection_nonuniform",
@@ -71,16 +73,15 @@ def __init__(self, solver_name, *, from_commandline=False):
         # -------------------------------------------------------------------------
 
         # parameter defaults
-        self.rp = runparams.RuntimeParameters()
+        self.rp = RuntimeParameters()
         self.rp.load_params(self.pyro_home + "_defaults")
         self.rp.load_params(self.pyro_home + self.solver_name + "/_defaults")
 
         self.tc = profile.TimerCollection()
 
         self.is_initialized = False
 
-    def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None,
-                           other_commands=None):
+    def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None):
         """
         Initialize the specific problem
 
@@ -92,8 +93,6 @@ def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None
             Filename containing problem's runtime parameters
         inputs_dict : dict
             Dictionary containing extra runtime parameters
-        other_commands : str
-            Other command line parameter options
         """
         # pylint: disable=attribute-defined-outside-init
 
@@ -128,10 +127,6 @@ def initialize_problem(self, problem_name, *, inputs_file=None, inputs_dict=None
             for k, v in inputs_dict.items():
                 self.rp.set_param(k, v)
 
-        # and any commandline overrides
-        if other_commands is not None:
-            self.rp.command_line_params(other_commands)
-
         # write out the inputs.auto
         self.rp.print_paramfile()
 
@@ -401,9 +396,15 @@ def main():
     else:
         pyro = Pyro(args.solver[0], from_commandline=True)
 
+    other = {}
+    for param_string in args.other:
+        k, v = param_string.split("=")
+        other[k] = _get_val(v)
+
+    print(other)
     pyro.initialize_problem(problem_name=args.problem[0],
                             inputs_file=args.param[0],
-                            other_commands=args.other)
+                            inputs_dict=other)
     pyro.run_sim()
 
 

pyro/util/runparams.py

@@ -163,36 +163,6 @@ def load_params(self, pfile, no_new=0):
 
                 self.param_comments[key] = comment.strip()
 
-    def command_line_params(self, cmd_strings):
-        """
-        finds dictionary pairs from a string that came from the
-        commandline.  Stores the parameters in only if they
-        already exist.
-
-        we expect things in the string in the form:
-        ["sec.opt=value",  "sec.opt=value"]
-        with each opt an element in the list
-
-        Parameters
-        ----------
-        cmd_strings : list
-            The list of strings containing runtime parameter pairs
-
-        """
-
-        for item in cmd_strings:
-
-            # break it apart
-            key, value = item.split("=")
-
-            # we only want to override existing keys/values
-            if key not in self.params:
-                msg.warning("warning, key: %s not defined" % (key))
-                continue
-
-            # check in turn whether this is an integer, float, or string
-            self.params[key] = _get_val(value)
-
     def get_param(self, key):
         """
         returns the value of the runtime parameter corresponding to the