Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Brotli #339

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Brotli #339

wants to merge 2 commits into from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Jul 5, 2017

No description provided.

Lukasa
Lukasa suggested changes Jul 5, 2017
View reviewed changes
Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need some tests that actually exercise the brotli functionality.

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 5, 2017

Yes, but I'm not going to write them.

@Lukasa
Copy link
Member

Lukasa commented Jul 5, 2017

Ok, this will need to sit here until someone gets around to writing tests for it. 😁 Thanks for the work!

@peterbe
Copy link

peterbe commented Apr 24, 2019

Can we close this now?
Seems it's already there: https://github.com/Lukasa/hyper/blob/18b629b8487169870235fe13387e2ae03c178b9f/setup.py#L80 and https://github.com/Lukasa/hyper/blob/18b629b8487169870235fe13387e2ae03c178b9f/hyper/http20/response.py#L35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lukasa Lukasa Lukasa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KOLANICH @Lukasa @peterbe