write_hex_file: 'ext_addr_mode' parameter is now case-insensitive

python-intelhex · Jun 29, 2020 · 88a2e42 · 88a2e42
1 parent 6731f34
commit 88a2e42
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/intelhex/__init__.py b/intelhex/__init__.py
@@ -573,6 +573,8 @@ def write_hex_file(self, f, write_start_addr=True, eolstyle='native', byte_count
         minaddr = addresses[0] if addr_len else 0
         maxaddr = addresses[-1] if addr_len else 0
 
+        # make parameter case-insensitive
+        ext_addr_mode = ext_addr_mode.lower()
         # resolve extended address type
         if ext_addr_mode == 'linear':
             # enforces Extended Linear Address record type (default)

diff --git a/intelhex/test.py b/intelhex/test.py
@@ -1798,12 +1798,44 @@ def test_write_hex_file_byte_count_255(self):
 
 class TestWriteHexFileExtAddrMode(unittest.TestCase):
 
-    def test_write_hex_file_wrong_ext_addr_mode(self):
+    def test_write_hex_file_ext_addr_mode_param(self):
         ih = intelhex.IntelHex()
         sio = StringIO()
+
+        # invalid param
         self.assertRaises(ValueError, ih.write_hex_file, sio, ext_addr_mode='bad')
+
+        # insesitive casing check
+        isValueError = False
+        try:
+            ih.write_hex_file(sio, ext_addr_mode='AUTO')
+        except ValueError:
+            isValueError = True
+        self.assertFalse(isValueError)
+
+        isValueError = False
+        try:
+            ih.write_hex_file(sio, ext_addr_mode='Linear')
+        except ValueError:
+            isValueError = True
+        self.assertFalse(isValueError)
+
+        isValueError = False
+        try:
+            ih.write_hex_file(sio, ext_addr_mode='segmenT')
+        except ValueError:
+            isValueError = True
+        self.assertFalse(isValueError)
+
+        isValueError = False
+        try:
+            ih.write_hex_file(sio, ext_addr_mode='NoNe')
+        except ValueError:
+            isValueError = True
+        self.assertFalse(isValueError)
+
         sio.close()
-    
+
     def test_write_hex_file_no_starting_address_simple(self):
         #prepare
         ih = intelhex.IntelHex(StringIO(hex_simple))