Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve deprecation warnings #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

matt-loft
Copy link

The following warnings were output when running the tests:

venv/lib/python3.8/site-packages/nose/importer.py:12
  /home/matt.hanley/github/loft-orbital/python-vxi11/venv/lib/python3.8/site-packages/nose/importer.py:12: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    from imp import find_module, load_module, acquire_lock, release_lock

vxi11/vxi11.py:134
  /home/matt.hanley/github/loft-orbital/python-vxi11/vxi11/vxi11.py:134: DeprecationWarning: invalid escape sequence \d
    m = re.match('^(?P<prefix>(?P<type>TCPIP)\d*)(::(?P<arg1>[^\s:]+))'

vxi11/vxi11.py:135
  /home/matt.hanley/github/loft-orbital/python-vxi11/vxi11/vxi11.py:135: DeprecationWarning: invalid escape sequence \s
    '(::(?P<arg2>[^\s:]+(\[.+\])?))?(::(?P<suffix>INSTR))$',

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

This fixes them by updating the regex string and removing the dependency on nose in favor of simply assert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant