Improve canonicalisation for conditional keywords #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some conditional schemas are canonicalised very slow, consider this one:
On my machine, each
canonicalish
call takes ~ 30ms, but if the "if" schema is equal to "then" and there is no "else" (or it is truthy), then this condition is a no-op.It is slightly related to #64, where the example was not canonicalised to
{"not": {}}
, with this change it does, but it doesn't solve the general case withanyOf
, though (as per your comment)