Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tkrabel-db committed Aug 16, 2023
1 parent f504b4d commit c2922fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ jobs:
python-version: '3.8'
architecture: 'x64'
- run: python -m pip install --upgrade pip setuptools jsonschema
# If we don't install pycodestyle, pylint with throw an unused-argument error in pylsp/plugins/pycodestyle_lint.py:72
# This error cannot be resove by adding a pylint: disable=unused-argument comment ...
- run: pip install -e .[pylint,black,pycodestyle,pyflakes]
# If we don't install pycodestyle, pylint will throw an unused-argument error in pylsp/plugins/pycodestyle_lint.py:72
# This error cannot be resolved by adding a pylint: disable=unused-argument comment ...
- run: |
pip install -e .[pylint,pycodestyle,pyflakes]
pip install black
- name: Pylint checks
run: pylint pylsp test
- name: Code style checks
- name: Code style checks with black
run: black --check pylsp test
- name: Pyflakes checks
run: pyflakes pylsp test
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ Homepage = "https://github.com/python-lsp/python-lsp-server"
[project.optional-dependencies]
all = [
"autopep8>=1.6.0,<2.1.0",
"black>=23.7.0,<24.0",
"flake8>=5.0.0,<7",
"mccabe>=0.7.0,<0.8.0",
"pycodestyle>=2.9.0,<2.11.0",
Expand All @@ -40,7 +39,6 @@ all = [
"whatthepatch>=1.0.2,<2.0.0"
]
autopep8 = ["autopep8>=1.6.0,<2.1.0"]
black = ["black>=23.7.0,<24.0"]
flake8 = ["flake8>=5.0.0,<7"]
mccabe = ["mccabe>=0.7.0,<0.8.0"]
pycodestyle = ["pycodestyle>=2.9.0,<2.11.0"]
Expand Down

0 comments on commit c2922fc

Please sign in to comment.