Load rope_autoimport cache on workspace/didChangeConfiguration
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Small suggestion for you @tkrabel-db, the rest looks good to me.
Co-authored-by: Carlos Cordoba <[email protected]>
rchl
reviewed
Oct 14, 2023
Comment on lines
+245
to
+252
| """ | ||
| Initialize autoimport if it has been enabled through a | ||
| workspace/didChangeConfiguration message from the frontend. | ||
|
|
||
| Generates the cache for local and global items. | ||
| """ | ||
| if config.plugin_settings("rope_autoimport").get("enabled", False): | ||
| _reload_cache(config, workspace) |
There was a problem hiding this comment.
It could keep the last enabled state and only reload cache on setting actually changing. Otherwise it can trigger wasteful reloads on any other setting changing.
There was a problem hiding this comment.
Yeah, that's a good very idea, thanks @rchl!
@tkrabel-db, what do you think? We could use a global variable to track the plugin's enabled state and only reload the cache when changing from ENABLED = False to True.
staticf0x
pushed a commit
to staticf0x/python-lsp-server
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
How is this tested?
Manually, ensuring that autoimports works after sending a
workspace/didChangeConfigurationto the backend.