Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use %r to have a better log #584

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

tebeka
Copy link
Contributor

@tebeka tebeka commented Jul 24, 2024

When writing a client, I got the error:

2024-07-24 11:35:19,459 IDT - WARNING - pylsp._utils - Path  not in /home/miki/work/autokitteh/src/playground/lsp/nlp

The path was empty, changed the log to use %r so empty string will be printed as ''.

@ccordoba12 ccordoba12 added this to the v1.12.0 milestone Jul 24, 2024
@ccordoba12 ccordoba12 added the enhancement New feature or request label Jul 24, 2024
@ccordoba12
Copy link
Member

Hey @tebeka, thanks for your contribution! Please rebase your branch on top of the latest develop one to get the fixes to our tests.

@tebeka
Copy link
Contributor Author

tebeka commented Jul 25, 2024

Please rebase your branch on top of the latest develop one to get the fixes to our tests.

Done

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @tebeka!

@ccordoba12 ccordoba12 changed the title Use %r for better log Use %r to have a better log Jul 29, 2024
@ccordoba12 ccordoba12 merged commit 8a345b9 into python-lsp:develop Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants