Use a dict instead of a set for extra_deps

python-poetry · Aug 23, 2023 · b243837 · b243837
1 parent e7a8565
commit b243837
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/poetry/core/factory.py b/src/poetry/core/factory.py
@@ -179,7 +179,7 @@ def configure_package(
                 package=package, group="dev", dependencies=config["dev-dependencies"]
             )
 
-        extra_deps = set()
+        extra_deps = {}
         extras = config.get("extras", {})
         for extra_name, requirements in extras.items():
             extra_name = canonicalize_name(extra_name)
@@ -201,13 +201,18 @@ def configure_package(
                         continue
 
                     if req_extras:
-                        dep = dep.with_features((*dep.extras, *req_extras))
-                        extra_deps.add(dep)
+                        dep_extras = frozenset((*dep.extras, *req_extras))
+                        dep_key = (dep.name, dep_extras)
+                        if dep_key in extra_deps:
+                            dep = extra_deps[dep_key]
+                        else:
+                            dep = dep.with_features(dep_extras)
+                            extra_deps[dep_key] = dep
 
                     dep.in_extras.append(extra_name)
                     package.extras[extra_name].append(dep)
 
-        package.requires.extend(extra_deps)
+        package.requires.extend(extra_deps.values())
 
         if "build" in config:
             build = config["build"]