Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make default formats of include consistent ("sdist" only)… #773

Merged
merged 3 commits into from
Oct 13, 2024
Merged

make default formats of include consistent ("sdist" only)… #773

merged 3 commits into from
Oct 13, 2024

Conversation

radoering
Copy link
Member

@radoering radoering commented Oct 6, 2024 •
edited
Loading

… and refactor code for better maintainability

Related to: python-poetry/poetry#9691
Requires: python-poetry/poetry#9754

  • Added tests for changed code.
  • Updated documentation for changed code. (downstream)

@radoering radoering mentioned this pull request Oct 6, 2024
Merged
2 tasks
@Secrus
Copy link
Member

Secrus commented Oct 6, 2024 •
edited
Loading

I would still go with include being default only for sdist. It is most often used to include some extra files like docs or tests directories and those should not be placed in site-packages, as it would happen when included in wheels. Inclusion in wheels should be explicit with a note in docs about how it works and what happens when wheel format is used. Default inclusion in wheels is a bug in my eyes and it shouldn't work that way.

@radoering radoering marked this pull request as draft October 6, 2024 17:55
@radoering radoering mentioned this pull request Oct 11, 2024
Merged
2 tasks
@radoering radoering changed the title make default formats of include consistent ("sdist" and "wheel")… make default formats of include consistent ("sdist" only)… Oct 11, 2024
@radoering
Copy link
Member Author

I would still go with include being default only for sdist.

OK, let's do it. I added a commit to change the default.

@radoering radoering marked this pull request as ready for review October 12, 2024 07:32
@radoering radoering enabled auto-merge (squash) October 13, 2024 20:28
@radoering radoering merged commit 1bdbd90 into python-poetry:main Oct 13, 2024
21 checks passed
radoering added a commit to radoering/poetry that referenced this pull request Oct 18, 2024
@radoering
use ref that includes python-poetry/poetry-core#773
97cc84d
radoering added a commit to radoering/poetry that referenced this pull request Oct 20, 2024
@radoering
use ref that includes python-poetry/poetry-core#773
6cdb9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Secrus Secrus Secrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoering @Secrus