Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use composite action for poetry setup #5789

Closed
wants to merge 4 commits into from

Conversation

abn
Copy link
Member

@abn abn commented Jun 6, 2022

No description provided.

@abn abn force-pushed the ci-use-composite-action branch from bda9fc7 to 1ca5927 Compare June 6, 2022 22:41
@Secrus
Copy link
Member

Secrus commented Jun 10, 2022

Wouldn't it be better to put action in separate repo under python-poetry org? That would separate concerns better I think.

@neersighted
Copy link
Member

Wouldn't it be better to put action in separate repo under python-poetry org? That would separate concerns better I think.

I don't think so as this is intended for use in this repo only. I have been meaning to compare the use of a reusable workflow with this method, as the reusable workflow won't be exposed out of this repo and thus won't tempt people to depend on it.

@Secrus
Copy link
Member

Secrus commented Mar 26, 2024

Superseded by the recent CI changes

@Secrus Secrus closed this Mar 26, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants