-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #8253
Misc fixes #8253
Conversation
if len(unsatisfied) == 1: | ||
dependency = unsatisfied[0] | ||
else: | ||
dependency = min(*unsatisfied, key=_get_min) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a performance optimization, but I suppose it does not matter. If it was an optimization it should have a comment telling us so anyway.
poetry is already using requests, and the docstring for requests.utils indicates that "this module provides utility functions ... that are also useful for external consumption". ie there's no reason copy the code, just use it.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
A small collection of updates and clean-ups: not fixing anything in particular but keeping current, preparing for deprecations, tightening type-checking, etc.
Probably best reviewed one commit at a time.