Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.md, describing the origin (not setting a readme) of Errno 21 and Errno 2 #8926

Closed
wants to merge 2 commits into from

Conversation

AFirooz
Copy link

@AFirooz AFirooz commented Jan 30, 2024

Describing the origin (not setting a readme) of "Errno 21" and "Errno 2".

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

Describing the origin (not setting a readme) of "Errno 21" and "Errno 2".
@Secrus
Copy link
Member

Secrus commented Jan 30, 2024

Could you provide some reproduction steps for the error you are describing? I don't think the team has ever heard of that case.

@Secrus Secrus added the status/waiting-on-response Waiting on response from author label Feb 7, 2024
@AFirooz
Copy link
Author

AFirooz commented Feb 8, 2024

Yes sure, here is a reproduction of the problem.

# creating a temp dir to work in
tmpdir=$(mktemp -d -t 'poetry_tst.XXXXXXXXXX')
cd $tmpdir

# set pyenv if you have it installed, I'm using python version 3.10.13
# pyenv local 3.10.13

# testing poetry code
poetry init -q
# add some package
poetry add numpy
poetry install

You will notice that the output has this warning message, this message will also appear if README.md is in a parent directory (like a readme for a related bigger project):

The current project could not be installed: [Errno 2] No such file or directory: '/tmp/poetry_tst.XXXXXXXXXX/README.md'
If you do not want to install the current project use --no-root

Things that I tried:

  1. Leaving the readme empty in pyproject.toml like readme = "". Output of poetry install:
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: poetry-tst-bb4mmvspd8 (0.1.0)
[Errno 21] Is a directory: '/tmp/poetry_tst.BB4Mmvspd8'
  1. Deleting the readme line completely from the pyproject.toml before adding a package and installing (This is a desired output). Output of poetry install:
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: poetry-tst-bb4mmvspd8 (0.1.0)
/tmp/poetry_tst.BB4Mmvspd8/poetry_tst does not contain any element
  1. Adding even an empty README.md file before running poetry install (This is also a desired output). Output of poetry install:
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: poetry-tst-bb4mmvspd8 (0.1.0)
/tmp/poetry_tst.BB4Mmvspd8/poetry_tst does not contain any element

@dimbleby
Copy link
Contributor

dimbleby commented Feb 8, 2024

what you have written in the docs does not add anything to what the warning message already says

@radoering radoering removed the status/waiting-on-response Waiting on response from author label Feb 10, 2024
@radoering
Copy link
Member

A agree with dimbleby. Nevertheless, thanks for your contribution.

@radoering radoering closed this Feb 10, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants