Downloader support resume from connection reset

[austinzh]

Pull Request Check List

Resolves: #3219
Resolves: #9551

• Added tests for changed code.
• Updated documentation for changed code.

[radoering]

download_file() is used in some more places (HTTPRepository, DirectOrigin), which might not be relevant for installing but only for locking. Maybe, connection resets are not that relevant for locking. On the other side, it feels more consistent to also retry in this case. What do you think?

HTTPRepository already has the config available, so it is easy to use the setting. For DirectOrigin, we had to add another parameter.

[radoering]

Reminder to myself: The next version might be 2.0.0.

[austinzh]

download_file() is used in some more places (HTTPRepository, DirectOrigin), which might not be relevant for installing but only for locking. Maybe, connection resets are not that relevant for locking. On the other side, it feels more consistent to also retry in this case. What do you think?

HTTPRepository already has the config available, so it is easy to use the setting. For DirectOrigin, we had to add another parameter.

Sure. I can add parameter to them, It's my first time working in this repo, I agree that even they are not much needed for retry it's better to make it all consistent.

But for the config, should we still use installer.max-retries? I think it's still valid name right? Or we add solver.max-retries ?
@radoering

[radoering]

But for the config, should we still use installer.max-retries? I think it's still valid name right? Or we add solver.max-retries ?

Good question. Thinking about it, installer.max-retries might have been a bit ambiguous from the start: We only retry the download not the complete installation. I think we should introduce a new section, maybe call it network or requests? (We already have a POETRY_REQUESTS_TIMEOUT, which is not yet available via config but only via environment variable; anyway, I think that one would fit into the same section.)

[austinzh]

Change config to "requests.max-retries"

[SmartManoj]

Please reopen #3219 to close the duplicate of #9551

[radoering]

Please reopen #3219 to close the duplicate of #9551

I do not think reopening #3219 makes sense because it is was closed a long time ago. Generally, we do not need an issue if we already have a PR. However, since some users only search issues, I think it is ok to keep #9551 open until this one is merged.

[SmartManoj]

Does this PR need any change?

[radoering]

Does this PR need any change?

I think all my comments have been addressed but I still have to review the changes. I won't have time for the next two weeks but feel free to remind me end of August if I have not come back to this issue by then.

[github-actions]

Deploy preview for website ready!

✅ Preview
https://website-8c1zr2f5e-python-poetry.vercel.app

Built with commit f8db472.
This pull request is being automatically deployed with vercel-action

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.