Implement an OIDC-based backend for uc-cdis/fence #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fence repo: https://github.com/uc-cdis/fence
TODOs:
Fence does not support
nonce
(see Includenonce
claim in the ID token uc-cdis/fence#600 )---a required claim by psa (and oidc specifications)---that results inAuthTokenError
exception:social-core/social_core/backends/open_id_connect.py
Lines 134 to 143 in 000f8e5
Hence, either psa should make
nonce
optional (Allow nonce to be optional in OIDC Authorization workflow #315) or Fence implement it. IMHO, based on OIDC-specs (see the following quote), the latter is preferred.