Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async124 yield-in-asynccm-not-in-try #307

Closed
wants to merge 1 commit into from

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Oct 25, 2024

last part of #262, though I'm not 100% on whether this should be a rule in flake8-async.

have not bumped version or added to changelog, and will extend the tests if we decide to go ahead.
(and if not make sure the fix to Visitor102.Visit_Try gets merged elsewhere)

@Zac-HD
Copy link
Member

Zac-HD commented Oct 25, 2024

I'd lean towards "don't bother doing this", since we're already covering the try/finally case I think there aren't any awaits that wouldn't already be warned-about.

@jakkdl
Copy link
Member Author

jakkdl commented Oct 28, 2024

I'd lean towards "don't bother doing this", since we're already covering the try/finally case I think there aren't any awaits that wouldn't already be warned-about.

right, I guess if the yield raises then any awaits can't cause any problems so this is about a completely different problem that's fairly well known and usually quite noticeable when it's not followed.

@jakkdl jakkdl closed this Oct 28, 2024
@jakkdl jakkdl deleted the yield-in-asynccm-not-in-try branch November 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants