Release 0.12.0 #94

shamrin · 2020-12-31T15:24:44Z

Release notes screenshot

TODO

Fixes #93

…e 0.10.0

…10.0

shamrin · 2021-01-01T22:11:00Z

pyproject.toml

+[[tool.towncrier.type]]
+directory = "misc"
+name = "Miscellaneous"
+showcontent = true


The showcontent = true line above is the whole reason for changing towncrier config. Otherwise, misc notes are missing their content in history.rst. I did it the same way as in trio: https://github.com/python-trio/trio/blob/master/pyproject.toml

shamrin · 2021-01-02T10:19:34Z

tests/test_misc.py

@@ -352,7 +228,7 @@ async def run_asyncio_loop(nursery, *, task_status=trio.TASK_STATUS_IGNORED):
                # Trigger KeyboardInterrupt that should propagate accross the coroutines
                signal.pthread_kill(threading.get_ident(), signal.SIGINT)

-
+@pytest.mark.xfail(reason="https://github.com/python-trio/trio-asyncio/issues/95", raises=RuntimeError)


This change makes CI green. See also #95.

Thanks for diagnosing this. I just uploaded #96 which appears to fix it. Probably worth incorporating into the release?

smurfix · 2021-01-02T11:00:58Z

The test error is from Python 3.10 which dropped a heap of loop=loop parameters from Future, Event et al.

I'm building a minimal patch; more extensive de-loop-argument-ization (in trio-asyncioproper) makes sense but requires deprecation warnings.

required for for Python 3.10+

codecov · 2021-01-02T11:15:49Z

Codecov Report

Merging #94 (a18c2b4) into master (b93c320) will increase coverage by 1.16%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   80.64%   81.81%   +1.16%     
==========================================
  Files          11       11              
  Lines        1240     1193      -47     
  Branches      172      172              
==========================================
- Hits         1000      976      -24     
+ Misses        170      154      -16     
+ Partials       70       63       -7

Impacted Files	Coverage Δ
trio_asyncio/__init__.py	`100.00% <ø> (ø)`
trio_asyncio/_loop.py	`79.32% <50.00%> (+0.63%)`	⬆️
trio_asyncio/_adapter.py	`81.19% <100.00%> (+1.03%)`	⬆️
trio_asyncio/_base.py	`84.14% <100.00%> (-0.64%)`	⬇️
trio_asyncio/_util.py	`84.09% <100.00%> (ø)`
trio_asyncio/_version.py	`100.00% <100.00%> (ø)`
trio_asyncio/_deprecate.py	`100.00% <0.00%> (+19.44%)`	⬆️

shamrin · 2021-01-02T12:27:02Z

@smurfix Thank you! I considered doing this change myself, but I thought it would make trio-asyncio Python 3.8+ only. Test results are proving me wrong :)

shamrin · 2021-01-03T11:07:12Z

Code coverage got lower. Most of it is due to _deprecate module. We use much less of it now, due to removed deprecations. Options (ordered by increasing difficulty):

copy test_deprecate from Trio and adapt it (easiest)
remove unused functionality from _deprecate module
extract _deprecate to its own package and use it in both trio and trio-asyncio

Update: I did port test_deprecate from Trio and codecov is finally happy. 👇

…await__

shamrin · 2021-01-03T21:15:41Z

trio_asyncio/_loop.py

@@ -344,7 +342,7 @@ async def _waitpid(self, pid, callback, *args):

    def add_child_handler(self, pid, callback, *args):
        """Add a callback to run when a child process terminates."""
-        h = self._loop.run_trio(self._waitpid, pid, callback, *args)
+        h = self._loop.trio_as_future(self._waitpid, pid, callback, *args)


Codecov is not happy about this line. It was never covered by tests before, and I have no idea how to test it now. However, the change is equivalent to what it was previously:

@deprecated("0.10.0", issue=38, instead="trio_as_aio(proc)(*args)") def run_trio(self, proc, *args): return self.trio_as_future(proc, *args)

docs/source/history.rst

oremanj · 2021-01-04T08:52:55Z

tests/test_misc.py

@@ -352,7 +228,7 @@ async def run_asyncio_loop(nursery, *, task_status=trio.TASK_STATUS_IGNORED):
                # Trigger KeyboardInterrupt that should propagate accross the coroutines
                signal.pthread_kill(threading.get_ident(), signal.SIGINT)

-
+@pytest.mark.xfail(reason="https://github.com/python-trio/trio-asyncio/issues/95", raises=RuntimeError)


Thanks for diagnosing this. I just uploaded #96 which appears to fix it. Probably worth incorporating into the release?

shamrin · 2021-01-04T11:05:59Z

@oremanj:

I just uploaded #96 which appears to fix it. Probably worth incorporating into the release?

Awesome, thank you! Yes, let's postpone the release until we get #96 merged.

(In the mean time, I've made the fixes you suggested.)

This reverts (cherry-picked) commits 8930bf2 and d1051b0. We will do the de-`loop=`-ification in PR python-trio#94.

oremanj · 2021-01-06T08:08:54Z

This LGTM. I merged #96 so once you incorporate that (and #99 maybe?) I think it's ready.

Intermittent test failures are now fixed by PR python-trio#96

oremanj · 2021-01-07T09:52:01Z

Interesting that this PR hasn't had any of the problems that the Mac builds have been having on other PRs. Those all seem to have failed around test_cancel_sleep_depr in test_misc.py, which is now gone. But I can't for the life of me figure out why test_cancel_sleep_depr would hang if the equivalent test_cancel_sleep works fine. Gremlins!

shamrin · 2021-01-07T14:53:13Z

@oremanj Now it did stuck at test_cancel_sleep. And I did find a way to replicate the issue locally. Issue coming soon!

Update: here is the issue - #103. Should we fix this deadlock before the release? Opinions?

No need for `raise Exception` because we already assert the flag. fixes python-trio#103

shamrin · 2021-01-08T00:16:49Z

"Fixed" the #103 deadlock in test_cancel_sleep by removing unnecessary raise Exception. The test would now fail with AssertionError rather than deadlock. I've also fiddled with timeout length to lower failure probability: 970d81c.

I think the underlying cause of deadlock is #104. No need to fix it for this release, because the problem was in v0.11.0 as well.

shamrin added 20 commits December 31, 2020 17:20

remove wrap_generator, deprecated since 0.10.0

cab2ea5

remove run_iterator, deprecated since 0.10.0

cbbb309

remove trio2aio, deprecated since 0.10.0

4d414a9

remove aio2trio, deprecated since 0.10.0

dee471c

remove run_future and TrioEventLoop.run_future, deprecated since 0.10.0

cdd808f

remove unused imports in _adapter

1e9ef9e

remove run_coroutine and TrioEventLoop.run_coroutine, deprecated sinc…

e01154a

…e 0.10.0

remove unused import in test_thread

a42b2c1

remove wrap_trio_context, deprecated since 0.10.0

f2ebc0a

remove TrioEventLoop.run_trio, deprecated since 0.10.0

518c29e

remove run_asyncio and TrioEventLoop.run_asyncio, deprecated since 0.…

64366e7

…10.0

remove unused imports in test_misc, test_adapter, test_callback

a61411c

temporarily disable flaky test_cancel_loop

d0bc23e

remove unused imports in _base, _loop

3cffc2a

configure towncrier to show Miscellaneous content

1c22295

mention that trio.hazmat TrioDeprecationWarning is gone now

f1f62c2

0.12.0 version

ba572d6

0.12.0 history

050fb3d

synchronize docstring: use recommended replacement for loop.run_trio

4465d26

remove poetry section

898a2a4

shamrin force-pushed the release-0.12.0 branch from 071052e to 898a2a4 Compare January 1, 2021 21:28

shamrin marked this pull request as ready for review January 1, 2021 21:34

mention issue python-trio#95 in xfail'ed test_cancel_loop

9a9f357

shamrin mentioned this pull request Jan 1, 2021

Intermittent test_cancel_loop failure #95

Closed

shamrin commented Jan 1, 2021

View reviewed changes

shamrin commented Jan 2, 2021

View reviewed changes

Python 3.10 drops the "loop" argument from "sleep"

e775879

Minimal de-loop=loop-ification

4476608

required for for Python 3.10+

shamrin added 4 commits January 3, 2021 13:16

port test_deprecate from Trio

b6f2c67

coverage: test no __await__ attribute case in Asyncio_Trio_Wrapper.__…

40fba89

…await__

coverage: test not Future case in allow_asyncio

917b4fe

coverage: test allow_asyncio(get_future_instance, ...)

a965a61

shamrin commented Jan 3, 2021

View reviewed changes

oremanj reviewed Jan 4, 2021

View reviewed changes

shamrin added 3 commits January 4, 2021 12:53

consistent history headings; fix towncrier config to match

5ca079a

correct issue link in history

c414430

clarify migration from removed API

3fb7a07

shamrin mentioned this pull request Jan 5, 2021

Cancel trio_as_aio tasks before stopping the trio-asyncio loop #96

Merged

shamrin added a commit to oremanj/trio-asyncio that referenced this pull request Jan 5, 2021

Revert "de-loop=loop-ification required for for Python 3.10+"

bcd5ab8

This reverts (cherry-picked) commits 8930bf2 and d1051b0. We will do the de-`loop=`-ification in PR python-trio#94.

oremanj and others added 3 commits January 6, 2021 02:12

Merge branch 'master' into release-0.12.0

950b0eb

enable previously disabled test (at d0bc23e)

c9b7bde

Intermittent test failures are now fixed by PR python-trio#96

rename test

0b7f978

pquentin approved these changes Jan 7, 2021

View reviewed changes

Merge branch 'master' into release-0.12.0

520768e

merge recent newsfragments

5006bee

stop test_cancel_sleep from deadlocking and less dependent on timer

970d81c

No need for `raise Exception` because we already assert the flag. fixes python-trio#103

version +dev

a18c2b4

shamrin merged commit fe01773 into python-trio:master Jan 8, 2021

shamrin deleted the release-0.12.0 branch January 8, 2021 01:05

shamrin mentioned this pull request Jan 8, 2021

How to ignore TrioDeprecationWarning only python-trio/trio#1833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.12.0 #94

Release 0.12.0 #94

shamrin commented Dec 31, 2020 •

edited

Loading

shamrin Jan 1, 2021 •

edited

Loading

shamrin Jan 2, 2021

oremanj Jan 4, 2021

smurfix commented Jan 2, 2021

codecov bot commented Jan 2, 2021 •

edited

Loading

shamrin commented Jan 2, 2021

shamrin commented Jan 3, 2021 •

edited

Loading

shamrin Jan 3, 2021 •

edited

Loading

oremanj Jan 4, 2021

shamrin commented Jan 4, 2021

oremanj commented Jan 6, 2021

oremanj commented Jan 7, 2021

shamrin commented Jan 7, 2021 •

edited

Loading

shamrin commented Jan 8, 2021 •

edited

Loading

Release 0.12.0 #94

Release 0.12.0 #94

Conversation

shamrin commented Dec 31, 2020 • edited Loading

Release notes screenshot

TODO

shamrin Jan 1, 2021 • edited Loading

Choose a reason for hiding this comment

shamrin Jan 2, 2021

Choose a reason for hiding this comment

oremanj Jan 4, 2021

Choose a reason for hiding this comment

smurfix commented Jan 2, 2021

codecov bot commented Jan 2, 2021 • edited Loading

Codecov Report

shamrin commented Jan 2, 2021

shamrin commented Jan 3, 2021 • edited Loading

shamrin Jan 3, 2021 • edited Loading

Choose a reason for hiding this comment

oremanj Jan 4, 2021

Choose a reason for hiding this comment

shamrin commented Jan 4, 2021

oremanj commented Jan 6, 2021

oremanj commented Jan 7, 2021

shamrin commented Jan 7, 2021 • edited Loading

shamrin commented Jan 8, 2021 • edited Loading

shamrin commented Dec 31, 2020 •

edited

Loading

shamrin Jan 1, 2021 •

edited

Loading

codecov bot commented Jan 2, 2021 •

edited

Loading

shamrin commented Jan 3, 2021 •

edited

Loading

shamrin Jan 3, 2021 •

edited

Loading

shamrin commented Jan 7, 2021 •

edited

Loading

shamrin commented Jan 8, 2021 •

edited

Loading