Use pidfd to implement trio.Process.wait, when available (2nd try) #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 106 106
Lines 13292 13326 +34
Branches 1004 1009 +5
=======================================
+ Hits 13253 13287 +34
Misses 24 24
Partials 15 15
|
|
Failure was: #200 (comment) I hit re-run jobs. |
|
Huh, now this is glitched out too. Maybe the problem is hitting re-run jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to #1296, but for some reason that PR has gotten
into a glitchy state where GH won't let it be merged. So I'm opening a
second PR in hopes that GH will somehow un-wedge themselves.
Fixes #1241