Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test more specific to prevent flakiness #1569

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 2, 2020

Sometimes ResourceWarnings decide to print during this test, and that
used to cause it to fail every once in a while.

Sometimes ResourceWarnings decide to print during this test, and that
used to cause it to fail every once in a while.
@njsmith
Copy link
Member Author

njsmith commented Jun 2, 2020

I was hoping #1565 would fix this, but then: https://github.com/python-trio/trio/pull/1568/checks?check_run_id=729466074

So we should probably fix it correctly...

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1569 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   99.68%   99.69%   +0.01%     
==========================================
  Files         110      111       +1     
  Lines       13498    13866     +368     
  Branches     1027     1059      +32     
==========================================
+ Hits        13455    13824     +369     
+ Misses         28       27       -1     
  Partials       15       15              
Impacted Files Coverage Δ
trio/tests/test_threads.py 100.00% <100.00%> (ø)
trio/lowlevel.py 100.00% <0.00%> (ø)
trio/_core/__init__.py 100.00% <0.00%> (ø)
trio/_core/_io_epoll.py 100.00% <0.00%> (ø)
trio/_core/_wakeup_socketpair.py 100.00% <0.00%> (ø)
trio/_core/tests/test_guest_mode.py 100.00% <0.00%> (ø)
trio/_core/_run.py 99.76% <0.00%> (+0.02%) ⬆️
trio/_core/_io_windows.py 98.57% <0.00%> (+0.03%) ⬆️
trio/_core/_ki.py 100.00% <0.00%> (+1.49%) ⬆️
trio/_core/_io_kqueue.py 85.00% <0.00%> (+1.98%) ⬆️

@pquentin pquentin merged commit b538cc3 into python-trio:master Jun 2, 2020
@njsmith njsmith deleted the stop-annoying-test-run-in-worker-thread-abandoned-flakiness branch June 2, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants